🎨 feat(colors): totally refactor color usage to make it possible to re-theme the app #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacroix
suggested changes
Sep 18, 2022
| @@ -1,6 +1,38 @@ | |||
| // Color branding below according to Publicis Sapient colors | |||
|
|
|||
| // Primary coolor is used as the baseline for the theme to appear in important | |||
There was a problem hiding this comment.
Not very confident that it will be updated in the long term 🤔
…e-theme the app Prior to this commit, a lot of colors where hardoded inside the "style" section of the .vue files. The color variables available for configuration in the variables.scss file and their usage was also blurry. This commit totally overhauls that, defining color variables by purpose and using them everywhere accordingly, effectively removing any hardcoded colors and allowing to re-theme the schedule more easily.
Horgix
force-pushed
the
color-refactoring
branch
from
9daea4b to
c287a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, a lot of colors where hardoded inside the "style" section of the
.vuefiles. The color variables available for configuration in thevariables.scssfile and their usage was also blurry.This overall made the re-theming of the App (e.g. for specific events) considerably hard.
This PR totally overhauls that, defining color variables by purpose (see the comments in the
variables.scssfile) and using them everywhere accordingly, effectively removing any hardcoded colors and allowing to re-theme the schedule more easily.This changes a tiny bit the app on some parts, see comparisons below
Schedule View
Before:
After:
TalkInfo View
Before:
After: