Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert button isn't making a dark background #310

Open
nstjean opened this issue Jan 8, 2020 · 13 comments
Open

Invert button isn't making a dark background #310

nstjean opened this issue Jan 8, 2020 · 13 comments

Comments

@nstjean
Copy link

nstjean commented Jan 8, 2020

I noticed that the invert button is causing some weird issues in my browser. The background is being set to black, and then the body is being inverted, which changes it back to white.

FireShot Capture 198 - Community toolbox - code publiclab org

This can be fixed by applying the filter:invert to the html tag instead of the body tag and removing the background-color: rgb(17, 17, 17); on the body tag.

@welcome
Copy link

welcome bot commented Jan 8, 2020

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@somenath1435
Copy link
Contributor

@nstjean Can I take up the issue?

@nstjean
Copy link
Author

nstjean commented Jan 9, 2020

@somenath1435 Go ahead!

@somenath1435
Copy link
Contributor

@nstjean As per the latest codebase in "main" branch, the issue is not there(Atleast in my system). Please check.

@nstjean
Copy link
Author

nstjean commented Jan 10, 2020

Ahhh, I see! That's interesting, as it seems to behave differently on the server than it does in local even though it's the same code. Could you investigate a little bit? It appears to have to do with the margin of the body tag.

@sunguru98
Copy link

If it's still incomplete means, may I take it please?

@nstjean
Copy link
Author

nstjean commented Jan 13, 2020

Hi @sunguru98 , @somenath1435 is investigating this issue.

@somenath1435
Copy link
Contributor

@sunguru98 you can take this issue

@aashimgarg
Copy link

i want to take this issue!

@sunguru98
Copy link

@aashimgarg The stage is yours.

@aashimgarg
Copy link

i think some of your npm dependencies are not installed.

@YogeshSharma01
Copy link
Contributor

Hi, @nstjean @somenath1435 @aashimgarg and @sunguru98 can I work on this?

@GuptaTanisha
Copy link

Hi @nstjean Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants