Implement useReducer for commentFormsVisibility #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /* eslint-disable complexity */ | ||
| import { makeDeepCopy } from "./helpers"; | ||
|
|
||
| const reducer = (state, action) => { |
There was a problem hiding this comment.
Function reducer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
| /* eslint-disable complexity */ | ||
| import { makeDeepCopy } from "./helpers"; | ||
|
|
||
| const reducer = (state, action) => { |
There was a problem hiding this comment.
Function reducer has 47 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -0,0 +1,58 @@ | |||
| /* eslint-disable complexity */ | |||
| import { makeDeepCopy } from "./helpers"; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Codecov Report
@@ Coverage Diff @@
## main #9862 +/- ##
=======================================
Coverage ? 82.09%
=======================================
Files ? 98
Lines ? 5942
Branches ? 0
=======================================
Hits ? 4878
Misses ? 1064
Partials ? 0 |
|
Code Climate has analyzed commit 0ba49ac and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Jun 30, 2021
|
Looks great, @noi5e !!!! |
17sushmita
pushed a commit
to 17sushmita/plots2
that referenced
this pull request
Jul 7, 2021
* implement useReducer for comment state management publiclab#9365 * rename commentFormToggleState to commentFormsVisibility publiclab#9365 * convert commentFormsVisibility state management to useReducer publiclab#9365 * create reducer action for hiding comment form publiclab#9365
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* implement useReducer for comment state management publiclab#9365 * rename commentFormToggleState to commentFormsVisibility publiclab#9365 * convert commentFormsVisibility state management to useReducer publiclab#9365 * create reducer action for hiding comment form publiclab#9365
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* implement useReducer for comment state management publiclab#9365 * rename commentFormToggleState to commentFormsVisibility publiclab#9365 * convert commentFormsVisibility state management to useReducer publiclab#9365 * create reducer action for hiding comment form publiclab#9365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a React rewrite of the commenting system, see #9365 for more context.
This PR is a follow-up to #9801. In that PR, I started to implement React's
useReducerto handle state management, which is becoming more complex.Basically, #9801 converted
state'scommentsobject touseReducer. This PR convertsstate'scommentFormsVisibilitytouseReducer.commentFormsVisibilityis a bit of data in statethat models whether or not an edit/reply comment form is visible on the page(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)