Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect prioritization and democratic flow of processing requests #982

Closed
dnsguru opened this issue Feb 26, 2020 · 20 comments
Assignees

Comments

@dnsguru
Copy link
Member

dnsguru commented Feb 26, 2020

Looking for some help in defining an order of processing from @weppos @sleevi to document the factors that impact prioritization and pace of processing requests within our volunteer pool.

The queue and order of PR received for processing is something that I want to try to further define in the documentation.

I'd like to update to the documentation that shows factors impacting processing and potentially identifies the order of processing of updates to the PSL in a manner that should hopefully attract submissions to flow through using the main funnel over other options.

I have reviewed the spectrum of PR and tried to capture the majority of the scenarios that come in to us. The following list is a starting draft to start the discussion of the order of processing (including a category for where it will not be processed)

Glossary:

  • 1st party = validated first party by match to admin contact
  • 3rd party = non-validated party or community submission
  • DNS Validated = the PR number validation record present for DNS _psl TXT validation

The following is the list of submission types we receive

  • Any Submissions for entries outside ICP-3 defined through vetted IETF,IANA,ICANN process (ex:.ONION Add onion #386) by 1st or 3rd party
  • Automated updates from ICANN v2 json performing additions/removals of gTLDs from ICANN Section of PSL
  • ICANN Section add submitted by 1st party ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL that are DNS validated
  • ICANN Section update submitted by 1st party gTLD, ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL that are DNS validated
  • ICANN Section add submitted by 3st party ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL that are DNS validated
  • ICANN Section update submitted by 3st party gTLD, ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL that are DNS validated
  • PRIVATE Section add submitted by 1st party that are DNS validated
  • PRIVATE Section update submitted by 1st party that are DNS validated
  • PRIVATE Section add submitted by 3rd party that are DNS validated
  • PRIVATE Section update submitted by 3rd party that are DNS validated
  • ICANN Section add submitted by 1st party ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL NOT DNS validated
  • ICANN Section update submitted by 1st party gTLD, ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL NOT DNS validated
  • ICANN Section add submitted by 3st party ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL NOT DNS validated
  • ICANN Section update submitted by 3st party gTLD, ccTLD or IDNccTLD present in IANA root TLD zone file but not in ICANN Section of PSL NOT DNS validated
  • PRIVATE Section add submitted by 1st party that are DNS validated
  • PRIVATE Section update submitted by 1st party that are DNS validated
  • PRIVATE Section add submitted by 3rd party that are DNS validated
  • PRIVATE Section update submitted by 3rd party that are DNS validated
  • PRIVATE Section deletion submitted by 1st party NOT DNS validated
  • PRIVATE Section deletion submitted by 1st party that are DNS validated
  • PRIVATE Section deletion submitted by 3rd party NOT DNS validated
  • PRIVATE Section deletion submitted by 3rd party that are DNS validated

Worth noting that these things are unlikely to be addressed

  • Any Submissions for TLDs in alternative roots (ie not ICP-3 compliant) by 1st or 3rd party
  • Any Submissions for IPv4 or IPv6 addresses or ARPA.INT
  • Entries whose sole purpose is to circumvent Let's Encrypt rate limits
@dnsguru
Copy link
Member Author

dnsguru commented Feb 26, 2020

Documentation for assistance in roadmap #671

@sleevi
Copy link
Contributor

sleevi commented Feb 26, 2020

This is a very complex ontology, and I'm not sure it's correct. For example, I'm unaware of any examples of 3rd party submissions that are DNS validated. Do you have examples?

@dnsguru
Copy link
Member Author

dnsguru commented Feb 26, 2020 via email

@sleevi
Copy link
Contributor

sleevi commented Feb 26, 2020 via email

@dnsguru
Copy link
Member Author

dnsguru commented Feb 26, 2020

You’re saying someone other than the registry modified the DNS records?

No no no no no... I am saying that I, as a third party to the registry, submitted the PR and the DNS was updated accordingly by the registry.

@dnsguru
Copy link
Member Author

dnsguru commented Feb 26, 2020

Thinking of it as 4 dimensions - First or Third party, Validated DNS with _PSL (or not), Add/Delete/Modify, and what Section (ICANN or PRIVATE)

  • First Party, Validated DNS, Add, ICANN Section
  • First Party, Validated DNS, Add, PRIVATE Section
  • First Party, Validated DNS, Modify, ICANN Section
  • First Party, Validated DNS, Modify, PRIVATE Section
  • First Party, Validated DNS, Delete, ICANN Section
  • First Party, Validated DNS, Delete, PRIVATE Section
  • Third Party, Validated DNS, Add, ICANN Section
  • Third Party, Validated DNS, Add, PRIVATE Section
  • Third Party, Validated DNS, Modify, ICANN Section (Update fj entry #964)
  • Third Party, Validated DNS, Modify, PRIVATE Section
  • Third Party, Validated DNS, Delete, ICANN Section
  • Third Party, Validated DNS, Delete, PRIVATE Section
  • First Party, No DNS Validation, Add, ICANN Section
  • First Party, No DNS Validation, Add, PRIVATE Section
  • First Party, No DNS Validation, Modify, ICANN Section
  • First Party, No DNS Validation, Modify, PRIVATE Section
  • First Party, No DNS Validation, Delete, ICANN Section (Removal of education.tas.edu.au #977)
  • First Party, No DNS Validation, Delete, PRIVATE Section
  • Third Party, No DNS Validation, Add, ICANN Section
  • Third Party, No DNS Validation, Add, PRIVATE Section
  • Third Party, No DNS Validation, Modify, ICANN Section
  • Third Party, No DNS Validation, Modify, PRIVATE Section
  • Third Party, No DNS Validation, Delete, ICANN Section
  • Third Party, No DNS Validation, Delete, PRIVATE Section

@sleevi
Copy link
Contributor

sleevi commented Feb 26, 2020 via email

@dnsguru
Copy link
Member Author

dnsguru commented Feb 26, 2020 via email

@weppos
Copy link
Member

weppos commented Feb 27, 2020

Personally, I apply the following priority:

  1. Requests related to ICANN/IANA suffixes are processed first
  2. Anything in PRIVATE afterwards

Within 2. I tend to give a slightly higher priority to issues that modify or remove existing entries. The reasoning behind that is because those requests are generally easier to handle as the contributor has past experience, hence I can expect a lower LOE.

I'm open to hear alternative approaches, but I'd suggest we don't come with a process that introduces more overhead than the one we try to solve. I like to keep things simple. 😉

@dnsguru
Copy link
Member Author

dnsguru commented Feb 27, 2020

OK, so I think the answer is that there are some dimensions to how we process these. Tweak or comment:

LoE, impacts the pace of processing, validation or merge of a contribution

This project has a number of contributors, most all of whom are volunteers. To best process things in the most efficient manner, the following are some factors and dimensions that can impact the order and pace of processing by the volunteers.

What type of change is being requested?

  • Additions typically require lower LoE
  • Modifications/Deletions are higher LoE

Contributor frequency (new vs repeat) submitting party might indicate experience or familiarity that may make the reduce the LoE, or may be posting frequent changes indicating circumstances of higher LoE from closer review.

Validation of submission(s): ALWAYS

This has a range of LoE. These are not mutually exclusive validation techniques, and the bias is the DNS validation as it is difficult or impossible to forge. The other methods create a burden of research for the volunteers and severely impact the pace of processing or prioritization.

  • On the lower side of LoE, Zone validation via DNS and _PSL TXT RFC8553-style record matching the PR# will help prove that there is a connection between the authoritative admin or domain owner and the submitted PR.
  • Documented, publicly available policies or enumeration / explanation of the submission from an authoritative source
  • Was this submitted directly from the registry or domain owner?

Request size and complexity can also impact the LoE and pace of processing:

  • Is this a modification that moves entries in whole or in part from one section to another section?
  • Is this a request that has a lot of domains to validate?
  • Are there a number of clarifying questions that the contributor or the volunteers must pose?

@sleevi
Copy link
Contributor

sleevi commented Feb 27, 2020

Relative to additions, additions are not all equal.

  • Does this have the template filled out in a way that answers the common questions
    • Why is it being requested
    • What are example domains (this is particularly important with respect to wildcards and doing the right thing)
  • How many domains are being requested
  • Are the domains being requested for internal purposes (e.g. organization Foo wants their dev/staging servers, which only they use/access) or for general utility
    • Basically, does every user shipping the PSL benefit from the added size/processing?
  • What's the registration period for the domain (i.e. the risk of churning)

I totally admit, I'm not thrilled with having to ask these questions. They're an unfortunate and necessary evil involved with a static list, which is a result of cookies being scoped to "domains" (boundaries) and not merely hosts.

@dnsguru
Copy link
Member Author

dnsguru commented Feb 28, 2020 via email

@dnsguru
Copy link
Member Author

dnsguru commented Feb 28, 2020

I appreciated the inputs @weppos and @sleevi. I want to keep it simple, but we have to also recognize that many of the people submitting issues or PR are not familiar with some of the factors that can reduce or increase the success and time requirements of them.

Here is the latest, incorporating more inspired from the thread and our empirical experience, in the hopes we're helping users better understand how they can best compose their PR by providing us important information, and have a sense for factors that can impact the time or success.

New Version, Below

LoE, impacts the pace of processing, validation or merge of a contribution

This project has a number of contributors, most all of whom are volunteers. To best process things in the most efficient manner, the following are some factors and dimensions that can impact the order and pace of processing by the volunteers.

What type of change is being requested?

  • Additions typically require lower LoE than Modifications/Deletions; However...
  • Modifications/Deletions are higher LoE

All additions secnarios are not equal, and there are factors that can cause things to take longer or not happen (see "Information furnished in the PR template")

Contributor frequency (new vs repeat) submitting party might indicate experience or familiarity that may make the reduce the LoE, or may be posting frequent changes indicating circumstances of higher LoE from closer review.

Information furnished in the PR template (THOROUGH)

Questions and clarifications, research or review may or may not be needed, based upon the completeness, clarity, and accuracy of the submission.

  • Does the PR have the template filled out completely and clearly in a way that answers the common questions
    • Why is the PR being requested? Please be detailed, but not so detailed as to lose the reviewer(s) in the weeds.
    • What are example domains' use scenarios? Describe the desired outcome. Enumerate through example subdomains or the name iteself and how these are desired to work as a result of the PR being merged. This is particularly important with respect to wildcards (*) and bangs (!) and ensuring the result will align with the request.
  • How many domains are being requested within the PR?
  • Are the domains being requested for internal purposes (e.g. organization Foo wants their dev/staging servers, which only they use/access) or is this for general utility
    • Basically, does every user shipping the PSL benefit from the added size/processing?
  • What's the registration period for the domain (if in the PRIVATE section)? (i.e. the risk of churning)

Validation of submission(s): (ALWAYS)

This has a range of LoE. These are not mutually exclusive validation techniques, and the bias is the DNS validation as it is difficult or impossible to forge. The other methods create a burden of research for the volunteers and severely impact the pace of processing or prioritization.

  • On the lower side of LoE, Zone validation via DNS and _PSL TXT RFC8553-style record matching the PR# will help prove that there is a connection between the authoritative admin or domain owner and the submitted PR.
  • Documented, publicly available policies or enumeration / explanation of the submission from an authoritative source
  • Was this submitted directly from the registry or domain owner? (if Registry, does this match IANA database in some verifiable manner)

The first one is the most crucial. The other two are helpful. Having all three makes things go VERY quickly in the ICANN section.

Request size and complexity can also impact the LoE and pace of processing:

  • Is this a modification that moves entries in whole or in part from one section to another section?
  • Is this a request that has a lot of domains to validate?
  • Are there a number of clarifying questions that the contributor or the volunteers must pose?

@dnsguru
Copy link
Member Author

dnsguru commented Feb 28, 2020

Updated the Guidelines based upon this issue. @sleevi @weppos take a look please.

@weppos
Copy link
Member

weppos commented Mar 2, 2020

Additions typically require lower LoE than Modifications/Deletions
Modifications/Deletions are higher LoE

Can you clarify? It's actually exactly the opposite for me. It's faster to deal with a modification than a brand new request. In most cases, same apply to deletion.

@dnsguru
Copy link
Member Author

dnsguru commented Mar 2, 2020 via email

@weppos
Copy link
Member

weppos commented Mar 3, 2020

Perhaps I need more context from @sleevi . From my experience:

  1. An addition is higher LOE because often comes with an education effort. I spend extra time looking into potential side effects the submitter did not consider, sometimes teaching the submitter about incorrect submissions or unexpected behaviors.
  2. Modifications (in terms of editing an existing entry or adding rules to an existing block) have lower LOE to me because I generally can skip the educational aspect as the submitter is in most cases already knowledgeable of the process.

I guess at this point I'm not sure whether stating the LOE in the guidelines has any valid interpretation from the eyes of the submitter. In other words, how is this information relevant?

@sleevi
Copy link
Contributor

sleevi commented Mar 3, 2020 via email

@dnsguru
Copy link
Member Author

dnsguru commented Mar 3, 2020 via email

@dnsguru
Copy link
Member Author

dnsguru commented Apr 16, 2020

Gonna close this one for now. Seems reasonably well addressed in the update I posted.

@dnsguru dnsguru closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants