Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update File Access to code to refere to PublishPress Permissions #1333

Open
stevejburge opened this issue Dec 28, 2024 · 2 comments
Open

Update File Access to code to refere to PublishPress Permissions #1333

stevejburge opened this issue Dec 28, 2024 · 2 comments
Assignees

Comments

@stevejburge
Copy link
Member

Currently it refers to Press Permit, the old plugin name
Screenshot 2024-12-28 at 3 43 07 PM

@agapetry
Copy link
Contributor

agapetry commented Jan 13, 2025

@richaferry Note that this .htaccess comment tag is searched to find and update existing entries. As a result, if the string is changed, you will need to do either of the following:

  • Change the existing insertWithMarkers() logic to check for both "BEGIN PublishPress Permissions" and "BEGIN Press Permit"

or...

  • Implement of plugin update script to modify existing "BEGIN Press Permit" entries in the uploads/.htaccess file to "BEGIN PublishPress Permissions". This would need to be done regardless of whether the File Access module is currently enabled, or tied to execution of File Access module init rather than plugin activation.

@stevejburge
Copy link
Member Author

OK, let's delay this to avoid any issues

@richaferry richaferry self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants