fix: issue of registered listener is not being remove on RemoveListen…

…er. (#227)

* fix: issue of registered listener is not being remove on RemoveListener.

* PubNub SDK v6.20.2.0 release.

---------

Co-authored-by: PubNub Release Bot <[email protected]>

.github/CODEOWNERS

@@ -1,2 +1,2 @@
-*         @mohitpubnub @xavrax @marcin-cebo
-README.md @techwritermat @kazydek @mohitpubnub @xavrax
+*         @mohitpubnub @xavrax @marcin-cebo @jakub-grzesiowski
+README.md @techwritermat @kazydek @mohitpubnub @xavrax @jakub-grzesiowski

.pubnub.yml

@@ -1,8 +1,13 @@
 name: c-sharp
-version: "6.20.1"
+version: "6.20.2"
 schema: 1
 scm: github.com/pubnub/c-sharp
 changelog:
+  - date: 2024-10-03
+    version: v6.20.2
+    changes:
+      - type: bug
+        text: "Fixes issue of listener not being removed on RemoveListener call."
   - date: 2024-05-09
     version: v6.20.1
     changes:
@@ -788,7 +793,7 @@ features:
     - QUERY-PARAM
 supported-platforms:
   -
-    version: Pubnub 'C#' 6.20.1
+    version: Pubnub 'C#' 6.20.2
     platforms:
       - Windows 10 and up
       - Windows Server 2008 and up
@@ -799,7 +804,7 @@ supported-platforms:
       - .Net Framework 4.6.1+
       - .Net Framework 6.0
   -
-    version: PubnubPCL 'C#' 6.20.1
+    version: PubnubPCL 'C#' 6.20.2
     platforms:
       - Xamarin.Android
       - Xamarin.iOS
@@ -819,7 +824,7 @@ supported-platforms:
       - .Net Core
       - .Net 6.0
   -
-    version: PubnubUWP 'C#' 6.20.1
+    version: PubnubUWP 'C#' 6.20.2
     platforms:
       - Windows Phone 10
       - Universal Windows Apps
@@ -843,7 +848,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: Pubnub
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.1.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.2.0
             requires:
               -
                 name: ".Net"
@@ -1126,7 +1131,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubNubPCL
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.1.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.2.0
             requires:
               -
                 name: ".Net Core"
@@ -1485,7 +1490,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubnubUWP
-            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.1.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v6.20.2.0
             requires:
               -
                 name: "Universal Windows Platform Development"

CHANGELOG

@@ -1,3 +1,7 @@
+v6.20.2 - October 03 2024
+-----------------------------
+- Fixed: fixes issue of listener not being removed on RemoveListener call.
+
 v6.20.1 - May 09 2024
 -----------------------------
 - Fixed: fixes issue of Unity SDK not being able to have a fully independent IJsonPluggableLibrary implementation because of direct nu-get Newtonsoft usage in C# SDK (Unity has it's own version that works with IL2CPP builds).

src/Api/PubnubApi/Properties/AssemblyInfo.cs

@@ -11,8 +11,8 @@
 [assembly: AssemblyProduct("Pubnub C# SDK")]
 [assembly: AssemblyCopyright("Copyright ©  2021")]
 [assembly: AssemblyTrademark("")]
-[assembly: AssemblyVersion("6.20.1.0")]
-[assembly: AssemblyFileVersion("6.20.1.0")]
+[assembly: AssemblyVersion("6.20.2.0")]
+[assembly: AssemblyFileVersion("6.20.2.0")]
 // Setting ComVisible to false makes the types in this assembly not visible
 // to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.

src/Api/PubnubApi/Pubnub.cs

@@ -412,15 +412,18 @@ public bool AddListener(SubscribeCallback listener)
             }
         }
 
-        public bool RemoveListener(SubscribeCallback listener)
-        {
-            bool ret = false;
-            if (subscribeCallbackListenerList != null)
-            {
-                ret = subscribeCallbackListenerList.Remove(listener);
-            }
-            return ret;
-        }
+		public bool RemoveListener(SubscribeCallback listener)
+		{
+			bool ret = false;
+			if (subscribeCallbackListenerList != null) {
+				ret = subscribeCallbackListenerList.Remove(listener);
+			}
+			if (listenerManager != null) {
+				var removeFromListenerManager = listenerManager.RemoveListener(listener);
+				if (!ret) ret = ret || removeFromListenerManager;
+			}
+			return ret;
+		}
         #endregion
 
         public EndPoint.SendFileOperation SendFile()

src/Api/PubnubApi/PubnubApi.csproj

@@ -14,15 +14,15 @@
 
   <PropertyGroup>
     <PackageId>Pubnub</PackageId>
-    <PackageVersion>6.20.1.0</PackageVersion>
+    <PackageVersion>6.20.2.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Fixes issue of Unity SDK not being able to have a fully independent IJsonPluggableLibrary implementation because of direct nu-get Newtonsoft usage in C# SDK (Unity has it's own version that works with IL2CPP builds).</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of listener not being removed on RemoveListener call.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

src/Api/PubnubApiPCL/PubnubApiPCL.csproj

@@ -15,15 +15,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubPCL</PackageId>
-    <PackageVersion>6.20.1.0</PackageVersion>
+    <PackageVersion>6.20.2.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Fixes issue of Unity SDK not being able to have a fully independent IJsonPluggableLibrary implementation because of direct nu-get Newtonsoft usage in C# SDK (Unity has it's own version that works with IL2CPP builds).</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of listener not being removed on RemoveListener call.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

src/Api/PubnubApiUWP/PubnubApiUWP.csproj

@@ -16,15 +16,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubUWP</PackageId>
-    <PackageVersion>6.20.1.0</PackageVersion>
+    <PackageVersion>6.20.2.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Fixes issue of Unity SDK not being able to have a fully independent IJsonPluggableLibrary implementation because of direct nu-get Newtonsoft usage in C# SDK (Unity has it's own version that works with IL2CPP builds).</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixes issue of listener not being removed on RemoveListener call.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

src/Api/PubnubApiUnity/PubnubApiUnity.csproj

@@ -15,7 +15,7 @@
 
   <PropertyGroup>
     <PackageId>PubnubApiUnity</PackageId>
-    <PackageVersion>6.20.1.0</PackageVersion>
+    <PackageVersion>6.20.2.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>