Mc/add membership type #151
Conversation
marcin-cebo
requested review from
wkal-pubnub and
jguz-pubnub
as code owners
marcin-cebo
force-pushed
the
mc/addMembershipType
branch
from
1e6e9db to
2a790ed
Compare
| @@ -110,12 +118,14 @@ data class MembershipImpl( | |||
| user, | |||
| update.custom?.value ?: custom, | |||
There was a problem hiding this comment.
actually I noticed an error in my code, it should be:
update.custom.let { newCustom -> if (newCustom != null) newCustom.value else custom },
and the new ones (status and type) should follow the same pattern
There was a problem hiding this comment.
What is a difference between:
update.custom?.value ?: custom,
and
update.custom.let { newCustom -> if (newCustom != null) newCustom.value else custom },
?
| includeCustom = true, | ||
| includeStatus = false, | ||
| includeType = false, | ||
| includeTotalCount = true, | ||
| includeChannel = true, | ||
| includeChannelCustom = true, | ||
| includeChannelType = true, | ||
| includeChannelStatus = false |
There was a problem hiding this comment.
we should probably set all includes to true everywhere, otherwise there's no way to get e.g. status and type for memberships, since the user can't override it
There was a problem hiding this comment.
Good point. I will check all cases where include params are needed.
In new version of PubNub core js sdk verbose logging has been added that slows down test execution.
marcin-cebo
force-pushed
the
mc/addMembershipType
branch
from
95bbb0f to
2bcaf27
Compare
|
@pubnub-release-bot release kotlin as 0.10.0 |
1 similar comment
|
@pubnub-release-bot release kotlin as 0.10.0 |
|
🚀 Release successfully completed 🚀 |
feat: Added status and type to Membership.