From 9b8a5764a28e0f9ab439dd75c32b8229500f31ae Mon Sep 17 00:00:00 2001
From: Ryan Laddusaw <rladdusaw@princeton.edu>
Date: Tue, 21 Jan 2025 17:10:18 -0500
Subject: [PATCH] Copy seleced items instead of moving to the top

---
 .../components/search--advanced.scss          |  6 ++
 .../multiselect_combobox_component.html.erb   | 10 +--
 .../orangelight/multiselect_combobox.es6      | 90 +++++++++++++------
 spec/features/advanced_searching_spec.rb      |  2 +-
 .../orangelight/multiselect_combobox.spec.js  | 10 ++-
 5 files changed, 82 insertions(+), 36 deletions(-)

diff --git a/app/assets/stylesheets/components/search--advanced.scss b/app/assets/stylesheets/components/search--advanced.scss
index e39b723d5..8f4315156 100644
--- a/app/assets/stylesheets/components/search--advanced.scss
+++ b/app/assets/stylesheets/components/search--advanced.scss
@@ -100,6 +100,12 @@
   white-space: normal;
 }
 
+.dropdown-item.divider {
+  pointer-events: none;
+  border-bottom: 1px solid black;
+  margin-bottom: 4px;
+}
+
 .row .range_limit input.range_begin,
 .row .range_limit input.range_end {
   width: 5em;
diff --git a/app/components/multiselect_combobox_component.html.erb b/app/components/multiselect_combobox_component.html.erb
index f2d131e62..f31471762 100644
--- a/app/components/multiselect_combobox_component.html.erb
+++ b/app/components/multiselect_combobox_component.html.erb
@@ -5,16 +5,16 @@
         aria-expanded="false" aria-controls="<%= @listbox_id %>">
     <span class="fa fa-caret-down" aria-hidden="true" data-bs-toggle="dropdown"></span>
     <ul class="dropdown-menu" role="listbox" aria-label="Options" id="<%= @listbox_id %>">
-        <% @values.each do |value| %>
+        <% if @field_name == 'advanced_location_s' %>
             <%= content_tag :li,
-                value[:label],
+                'All Princeton Holdings',
                 class: 'dropdown-item',
                 tabindex: -1,
                 role: 'option' %>
         <% end %>
-        <% if @field_name == 'advanced_location_s' %>
+        <% @values.each do |value| %>
             <%= content_tag :li,
-                'pul',
+                value[:label],
                 class: 'dropdown-item',
                 tabindex: -1,
                 role: 'option' %>
@@ -32,7 +32,7 @@
         <% end %>
         <% if @field_name == 'advanced_location_s' %>
             <%= content_tag :option,
-                'pul',
+                'All Princeton Holdings',
                 value: 'pul',
                 selected: params.dig('f_inclusive', 'advanced_location_s', 0) == 'pul' %>
         <% end %>
diff --git a/app/javascript/orangelight/multiselect_combobox.es6 b/app/javascript/orangelight/multiselect_combobox.es6
index ba3a6650e..24031e36e 100644
--- a/app/javascript/orangelight/multiselect_combobox.es6
+++ b/app/javascript/orangelight/multiselect_combobox.es6
@@ -24,7 +24,7 @@ export default class MultiselectCombobox {
     this.selectedOptions.toggle(item.firstChild.nodeValue);
     this.inputElement.value = this.selectedOptions.toString();
     this.#updateHiddenSelect();
-    this.#orderList();
+    this.#buildList();
   }
 
   updateOptionVisibility() {
@@ -51,7 +51,18 @@ export default class MultiselectCombobox {
 
   #addEventListeners() {
     this.listElement.querySelectorAll('li').forEach((item) => {
-      item.addEventListener('keyup', (event) => {
+      this.#addEventListener(item);
+    });
+    this.inputElement.addEventListener('input', (event) => {
+      this.updateOptionVisibility();
+      this.#openDropdownIfClosed();
+    });
+  }
+
+  #addEventListener(item) {
+    item.addEventListener(
+      'keyup',
+      (event) => {
         if (event.code == 'Enter') {
           this.toggleItem(item);
         } else {
@@ -61,19 +72,20 @@ export default class MultiselectCombobox {
             new KeyboardEvent('keyup', { key: event.key, code: event.code })
           );
         }
-      });
-      item.addEventListener('click', (event) => {
+      },
+      this
+    );
+    item.addEventListener(
+      'click',
+      (event) => {
         this.toggleItem(item);
         // Don't propagate the event to the bootstrap event
         // listener.  Otherwise, the dropdown closes every
         // time the user clicks on an item
         event.stopPropagation();
-      });
-    });
-    this.inputElement.addEventListener('input', (event) => {
-      this.updateOptionVisibility();
-      this.#openDropdownIfClosed();
-    });
+      },
+      this
+    );
   }
 
   #applySelections() {
@@ -91,6 +103,17 @@ export default class MultiselectCombobox {
       item.querySelectorAll('span').forEach((span) => span.remove());
       item.classList.remove('active');
       item.setAttribute('aria-selected', 'false');
+      const active = this.listElement.querySelectorAll('.active');
+      for (const element of active) {
+        if (
+          element.firstChild.textContent.trim() ===
+          item.firstChild.textContent.trim()
+        ) {
+          element.querySelector('span').remove();
+          element.classList.remove('active');
+          break;
+        }
+      }
     } else {
       item.innerHTML += icon;
       item.classList.add('active');
@@ -120,27 +143,36 @@ export default class MultiselectCombobox {
     }
   }
 
-  #orderList() {
-    [].slice
-      .call(this.listElement.children)
-      .sort(this.#compare)
-      .forEach(function (val, i) {
-        this.listElement.appendChild(val);
-      }, this);
-  }
+  #buildList() {
+    let selectedList = [];
+    let allOptions = [];
 
-  #compare(a, b) {
-    function toBoolean(value) {
-      return value === 'true' ? true : false;
-    }
+    [].slice.call(this.listElement.children).forEach(function (val, i) {
+      if (val.children.length > 0) {
+        let copy = val.cloneNode(true);
+        this.#addEventListener(copy);
+        selectedList.push(copy);
+      }
+      allOptions.push(val);
+      if (val.classList.contains('divider')) {
+        selectedList = [];
+        allOptions = [];
+      }
+    }, this);
 
-    if (
-      toBoolean(a.getAttribute('aria-selected')) !==
-      toBoolean(b.getAttribute('aria-selected'))
-    ) {
-      return toBoolean(a.getAttribute('aria-selected')) ? -1 : 1;
-    } else {
-      return a.textContent.localeCompare(b.textContent);
+    let divider = document.createElement('li');
+    divider.classList.add('dropdown-item', 'divider');
+    divider.tabIndex = -1;
+    divider.role = 'option';
+
+    if (selectedList.length > 0) {
+      selectedList.push(divider);
     }
+
+    selectedList = selectedList.concat(allOptions);
+    this.listElement.innerHTML = '';
+    selectedList.forEach(function (val) {
+      this.listElement.appendChild(val);
+    }, this);
   }
 }
diff --git a/spec/features/advanced_searching_spec.rb b/spec/features/advanced_searching_spec.rb
index d7c7ee258..ab61dfde7 100644
--- a/spec/features/advanced_searching_spec.rb
+++ b/spec/features/advanced_searching_spec.rb
@@ -53,7 +53,7 @@
     holding_location = find_field('advanced_location_s')
     holding_location.click
     drop_down = holding_location.sibling(".dropdown-menu")
-    expect(drop_down).to have_content("pul")
+    expect(drop_down).to have_content("All Princeton Holdings")
   end
 
   it 'allows searching by publication date', js: true do
diff --git a/spec/javascript/orangelight/multiselect_combobox.spec.js b/spec/javascript/orangelight/multiselect_combobox.spec.js
index 8d6cd868c..145ecd782 100644
--- a/spec/javascript/orangelight/multiselect_combobox.spec.js
+++ b/spec/javascript/orangelight/multiselect_combobox.spec.js
@@ -125,8 +125,9 @@ describe('MultiselectCombobox', () => {
                 </div>`;
       combobox = new MultiselectCombobox(document.querySelector('input'));
     });
-    it('Moves the active option to the top', () => {
+    it('Copies the active option to the top', () => {
       expect(document.querySelectorAll('li')[0].textContent).toEqual('Lewis');
+      expect(document.querySelectorAll('li')[3].textContent).toEqual('Lewis');
     });
     it('Adds a checkmark icon to the <li>', () => {
       expect(
@@ -146,5 +147,12 @@ describe('MultiselectCombobox', () => {
     it('Adds the text to the <input>', () => {
       expect(document.querySelector('input').value).toEqual('Lewis');
     });
+    it('Removes just the copied option', () => {
+      document.querySelectorAll('li')[0].click();
+      expect(document.querySelectorAll('li')[0].textContent).toEqual(
+        'Firestone'
+      );
+      expect(document.querySelectorAll('li')[1].textContent).toEqual('Lewis');
+    });
   });
 });