Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XBAR_DEMUX_BUS in core_region #22

Open
micprog opened this issue Jan 11, 2021 · 0 comments
Open

XBAR_DEMUX_BUS in core_region #22

micprog opened this issue Jan 11, 2021 · 0 comments
Assignees
@OttG

Comments

@micprog
Copy link
Member

micprog commented Jan 11, 2021

In

pulp_cluster/rtl/core_region.sv

Line 147 in 339c2b8

XBAR_DEMUX_BUS s_core_bus(); // Internal interface between CORE <--> DEMUX
the s_core_bus is defined as a XBAR_DEMUX_BUS, but the additional signals provided by this bus (compared to XBAR_TCDM_BUS) are not used. Would it make sense to change this bus and simplify the code?

Additional signals:

  • barrier (0, not used)
  • busy (not connected, not used)
  • exec_cancel (0, not used)
  • exec_stall (0, not used)
  • r_gnt (0, not used in connected module(demux))
bluewww added a commit to bluewww/pulp_cluster that referenced this issue Jan 6, 2023
@bluewww
Merge branch 'update-cluster-interconnect-rebase-balasr' into 'master'
cbee72c 
Update pulp_cluster interconnect

# **Merge queue**

After !56, this branch root source

# **Overview**

This PR upgrades pulp_cluster interconnects aligning with the new version recently introduced in [pulp-open](pulp-platform/pulp#49) (still not in master).

# **Checklist**

- [x] Bump version of several cluster IPs (`pulp_cluster`, `icache_mp_128_pf`, `hier-icache`, `cluster_peripherals`, `cluster_interconnect`, `mchan`)
- [x] Bump `axi` to v0.28.0 
- [x] Glue the updated IP with control_pulp hw
- [x] Update CHANGELOG with more detailed information on IP bump versions and cluster interconnect changes
- [x] Adopt novel AXI clock domain crossing setup in the cluster-soc communication (required `axi >= v0.28.0`)
- [x] Adopt the use of 32-bit private icache to prevent issues arisen with Mobilenet workload in pulp-open (test still to be included here)

# **Fixes**

Fixes pulp-platform#22 

# **Notes** 

~~- I wasn't able to properly `git subtree pull` the `axi` repo. A lot of (unexpected) conflicts arised. To shorten the process, I removed the axi IP directory and called `git subtree add` again. This should not have implications on the history itself. Yet it is a bit of a ugly solution, but I hope non-blocking for the merge. 
Otherwise, we can figure out alternatives by rebasing~~

~~- I was able to bump some IPs without the `--squash` option only, perhaps because they were added in that flatten way originally as well. Again, hope this is not a blocking issue~~

**NB** Previous notes were fixed by workarounding `git subtree pull` command

See merge request balasr/control-pulp!67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OttG OttG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micprog @OttG