-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot make a release with the latest change to release.sh
#833
Comments
Consider that the current Release Pipeline action does not push the package to PyPI. It should dispatch a new workflow that uploads missing parts to PyPI, see c53c1e3. However, this does not seem to work at the moment. |
mdellweg
added a commit
to mdellweg/plugin_template
that referenced
this issue
Jan 24, 2024
When pushing with the default workflow token, you would need to disable the branch protection and the subsequent publish workflow will not trigger. Fixes pulp#833
mdellweg
added a commit
that referenced
this issue
Jan 24, 2024
When pushing with the default workflow token, you would need to disable the branch protection and the subsequent publish workflow will not trigger. Fixes #833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is not possible to perform a release without disabling all the selected options:

The following behaviour is observable in the pulp-container repository after applying the latest changes from the temaplate:
The issue is relevant to this line of code:
plugin_template/templates/github/.github/workflows/scripts/release.sh
Line 26 in 4288910
Not to forget that if the script fails to succeed, there is still a new tag created which results into the following error when trying to re-run the job:
The text was updated successfully, but these errors were encountered: