-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the is_modular flag from the Package model #3524
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The only place it's currently used is in depsolving and retention policy handling. IIRC, it exists mostly because it was done that way in Pulp 2 more than any other reason - but this design is problematic.
The module upload workflow (as opposed to syncing) requires that the packages themselves already be uploaded into Pulp beforehand - but there is no way to upload a package such that the
is_modular
flag will be set. Therefore this is not a reliable way to know whether a package is "modular" or not.Additionally we've had some problems with packages that have been synced as both part-of-a-module and not-part-of-a-module.
So, we need to ditch that field, and ensure that any mechanisms that need to know whether or not a package is modular can do so without that field being present.
The text was updated successfully, but these errors were encountered: