Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Partial browserAction implementation #60

Merged
merged 7 commits into from
Apr 26, 2024
Merged

🚧 Partial browserAction implementation #60

merged 7 commits into from
Apr 26, 2024

Conversation

trickypr
Copy link
Member

@trickypr trickypr commented Apr 21, 2024 •
edited
Loading

The goal is to implement just enough of the browser action api to resolve the error in #53.

Also see #20

@trickypr Graphite App
Copy link
Member Author

trickypr commented Apr 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @trickypr and the rest of your teammates on Graphite Graphite

@trickypr trickypr mentioned this pull request Apr 21, 2024
Merged
@trickypr trickypr changed the title 🚧 Implement browser_action manifest key backend 🚧 Partial browserAction implementation Apr 21, 2024
@trickypr trickypr mentioned this pull request Apr 22, 2024
Open
@trickypr trickypr marked this pull request as ready for review April 22, 2024 09:41
@trickypr trickypr mentioned this pull request Apr 22, 2024
Open
4 tasks
@trickypr trickypr force-pushed the fix-ext-browser-new-window-api branch from b9990c5 to 28632c9 Compare April 26, 2024 04:38
@trickypr trickypr force-pushed the 04-21-_implement_browser_action_manifest_key_backend branch from 56a19c5 to 564663c Compare April 26, 2024 04:38
@trickypr trickypr mentioned this pull request Apr 26, 2024
Draft
@trickypr Graphite App
Copy link
Member Author

trickypr commented Apr 26, 2024 •
edited
Loading

Merge activity

  • Apr 26, 1:15 AM EDT: @trickypr started a stack merge that includes this pull request via Graphite.
  • Apr 26, 1:16 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 26, 1:19 AM EDT: @trickypr merged this pull request with Graphite.

Base automatically changed from fix-ext-browser-new-window-api to artifact-based-browser April 26, 2024 05:15
@trickypr trickypr force-pushed the 04-21-_implement_browser_action_manifest_key_backend branch from 7c857ea to 401befb Compare April 26, 2024 05:16
@trickypr trickypr merged commit 1d8ae34 into artifact-based-browser Apr 26, 2024
5 checks passed
@trickypr trickypr deleted the 04-21-_implement_browser_action_manifest_key_backend branch April 26, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trickypr