Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting items in android app re-uploads the image/video as .trashed file. #1153

Closed
carnager opened this issue Apr 21, 2024 · 7 comments
Closed

Comments

@carnager
Copy link

carnager commented Apr 21, 2024

Describe the bug
Allow memories access to local files.
When I delete an item in the android app, instead of moving the item to trash, it renames it in the same folder the original image was stored. It then reuploads the image into the original images folder with name .trashed-1714492983-ORIGINAL_FILENAME.jpg
Checking the files app on my nextcloud instance, I can see that the original images were properly moved into the Trash folder.

To Reproduce
Delete an image in mobile app and say yes if it asks you for permissions to move images to trash.

Platform:
Android, GrapheneOS

  • Memories Version: 7.2.0
  • PHP Version: Not sure (Hosted instance on Hetzner)
@carnager carnager added the needs triage To be triaged label Apr 21, 2024
@pulsejet
Copy link
Owner

pulsejet commented May 1, 2024

Can confirm this is a bug in the Nextcloud Android app
nextcloud/android#10645

@pulsejet pulsejet closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@pulsejet pulsejet removed the needs triage To be triaged label May 1, 2024
@tuxArg
Copy link

tuxArg commented May 17, 2024

Hi @pulsejet, I'm sorry to comment on this closed issue.
I don't think the android client would be fixed (and technically it isn't a bug as a hidden file is also a file). But, maybe there's a way to include a "skip trashbin" option when deleting local files in memories?

@pulsejet
Copy link
Owner

With the newest version of memories, these files will automatically be excluded from indexing, so they won't show up in Memories.

Skipping the trashbin might be a good idea, since they will be in trash on the server anyway. Don't know what the APIs look like though.

@tuxArg
Copy link

tuxArg commented May 17, 2024

When these files are uploaded they aren't in trash on the server, they are just hidden (but its visibility can be toggled), so I don't think that excluding them from memories is the best approach because that would make harder for the user to find them and deleting them (considering that they already wanted to).

@pulsejet
Copy link
Owner

The assumption is that the android app would fix this issue, which is the right place to fix it. Hiding the files is a temporary solution. If the Android app decides not to fix this for whatever reason, an optional cron job can clean these up automatically once they're old enough.

@tuxArg
Copy link

tuxArg commented May 17, 2024

I understand. I think it is a nextcloud client issue too. But I think (maybe I'm wrong here) memories client should use same criteria than nextcloud client. If the client uploaded .trashed-xxx.jpg as a regular file then memories client should display that file too.

I think the best way to deal with them is just excluding from local trash bin preventing them from being created, if that's possible.

@pulsejet
Copy link
Owner

Files starting with a dot are always hidden. This is a feature, not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants