Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid code from logging-operator crds (properties containing periods) #15

Open
re-mscho opened this issue Nov 19, 2020 · 1 comment
Open
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript

Comments

@re-mscho
Copy link

The code generated from logging-operator crds has some syntax errors.
Source: banzaicloud/logging-operator

Some generated interface property names contain periods and are not quoted.
e.g. .../types/output.ts:

        export interface LoggingSpecFluentbitBufferStorage {
            storage.backlog.mem_limit?: string;
            storage.checksum?: string;
            storage.path?: string;
            storage.sync?: string;
        }

(crd2pulumi version v1.0.5)

@re-mscho re-mscho changed the title invalid code from logging-operator crds (properties containing periods) Invalid code from logging-operator crds (properties containing periods) Nov 19, 2020
@leezen leezen added the bug label Nov 24, 2020
@pgavlin pgavlin self-assigned this Dec 8, 2020
@infin8x infin8x added kind/bug Some behavior is incorrect or out of spec and removed bug labels Jul 10, 2021
@mattolenik mattolenik added language/javascript area/codegen Affects quality or correctness of generated code labels Jun 2, 2022
@blampe
Copy link
Contributor

blampe commented Sep 17, 2024

This is a variant of #43 or more generally pulumi/pulumi#15874 since punctuation is not currently stripped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript
Projects
None yet
Development

No branches or pull requests

6 participants