Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-manager produces invalid c# code #155

Closed
trondhindenes opened this issue Oct 17, 2024 · 1 comment
Closed

cert-manager produces invalid c# code #155

trondhindenes opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue

Comments

@trondhindenes
Copy link

What happened?

Running it like this:

crd2pulumi --dotnetName certManagerCrds --dotnet https://raw.githubusercontent.com/cert-manager/cert-manager/refs/heads/master/deploy/crds/crd-clusterissuers.yaml

seems to be missing a rule for handling hyphens in type names, the resulting ClusterIssuer.cs is invalid code because of hyphens in class names.

Example

Produces classes like:

        [Output("spec")]
        public Output<Pulumi.Kubernetes.Types.Outputs.Cert-manager.V1.ClusterIssuerSpec> Spec { get; private set; } = null!;

...which are invalid

Output of pulumi about

CLI          
Version      3.136.1
Go Version   go1.23.2
Go Compiler  gc

Host     
OS       ubuntu
Version  24.04
Arch     x86_64

This project is written in dotnet: executable='/usr/bin/dotnet' version='8.0.110'

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@trondhindenes trondhindenes added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 17, 2024
@rquitales
Copy link
Member

rquitales commented Oct 17, 2024

Closing as duplicate of #17 and #43.

@rquitales rquitales added resolution/duplicate This issue is a duplicate of another issue and removed needs-triage Needs attention from the triage team labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants