Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type ipAddressType for aws.alb.LoadBalancer #4684

Open
nicolashuby opened this issue Oct 30, 2024 · 1 comment
Open

Wrong type ipAddressType for aws.alb.LoadBalancer #4684

nicolashuby opened this issue Oct 30, 2024 · 1 comment
Labels
area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec

Comments

@nicolashuby
Copy link

nicolashuby commented Oct 30, 2024

Describe what happened

Unlike de description , "dualstack-without-public-ipv4" is not available in type IpAddressType for a alb .
A workaround is to use a lb that has string for type IpAddressType

Sample program

/**
     * Type of IP addresses used by the subnets for your load balancer. The possible values depend upon the load balancer type: `ipv4` (all load balancer types), `dualstack` (all load balancer types), and `dualstack-without-public-ipv4` (type `application` only).
     */
    ipAddressType?: pulumi.Input<IpAddressType>;
export declare const IpAddressType: {
    readonly Ipv4: "ipv4";
    readonly Dualstack: "dualstack";
};

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

CLI          
Version      3.120.0
Go Version   go1.22.4
Go Compiler  gc

Plugins
KIND      NAME        VERSION
resource  aws         6.56.1
resource  cloudflare  5.40.1
resource  datadog     4.34.1
language  nodejs      unknown

Host     
OS       ubuntu
Version  22.04
Arch     x86_64

This project is written in nodejs: executable='/home/****/.volta/bin/node' version='v18.18.0

Additional context

NA

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@nicolashuby nicolashuby added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 30, 2024
@corymhall
Copy link
Contributor

@nicolashuby thanks for reporting this! It looks like this is a bug due to our use of overlays

The fix to this should include two things

  1. We should handle this case in a similar way to aws_instance.instance_type and allow for both the overlay type and a plain string value.
  2. We should update the overlay types to include the new value
    "aws:alb/IpAddressType:IpAddressType": {
    ObjectTypeSpec: schema.ObjectTypeSpec{
    Type: "string",
    },
    Enum: []schema.EnumValueSpec{
    {Name: "Ipv4", Value: "ipv4"},
    {Name: "Dualstack", Value: "dualstack"},
    },
    },

@corymhall corymhall removed the needs-triage Needs attention from the triage team label Oct 30, 2024
@t0yv0 t0yv0 added area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction impact/breaking Fixing this issue will require a breaking change labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overlays Issues pertaining to language-specific overlay code such as CallbackFunction impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants