Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds: minimal schema computation not working with bridge upgrades #4702

Open
t0yv0 opened this issue Oct 31, 2024 · 2 comments
Open

Builds: minimal schema computation not working with bridge upgrades #4702

t0yv0 opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 31, 2024

Describe what happened

https://github.com/pulumi/pulumi-aws/actions/runs/11614217568/job/32341851869?pr=4694

We need to either make sure it gets recomputed as part of make tfgen or take it out of repo and compute it as part of build so it's not tracked in source.

Sample program

N/A

Log output

N/A

Affected Resource(s)

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added the kind/engineering Work that is not visible to an external user label Oct 31, 2024
@t0yv0 t0yv0 self-assigned this Oct 31, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 31, 2024
@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Oct 31, 2024
@flostadler
Copy link
Contributor

The same is true for provider upgrades as well

@t0yv0
Copy link
Member Author

t0yv0 commented Nov 22, 2024

I'm not 100% sure but I think @corymhall fixed it in #4823

If he didn't I'll pick up on Monday to tidy it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants