Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate EKS cluster property defaultAddonsToRemoves in favor of bootstrapSelfManagedAddons #4755

Open
flostadler opened this issue Nov 12, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features service/eks EKS issues

Comments

@flostadler
Copy link
Contributor

The defaultAddonsToRemove property was introduced to EKS cluster configuration to allow bootstrapping clusters without AWS's default components (coredns, vpc-cni, kube-proxy). This was implemented in a patch, through a workaround where the provider would:

  1. Create an EKS addon on cluster creation
  2. Delete it immediately after
  3. This effectively brought the cluster components under Pulumi's management before destroying them

Current Situation

AWS has now introduced native support for this functionality through the bootstrapSelfManagedAddons flag, which creates a blank cluster without default components.

Key differences:

  • defaultAddonsToRemove: Allows selective removal of specific addons
  • bootstrapSelfManagedAddons: All-or-nothing approach (creates a blank cluster). Is faster as it doesn't have to first install the components, adopt them and finally destroy them

Proposed Changes

  1. Mark defaultAddonsToRemove as deprecated
  2. Remove the property in the next major version

Required Investigation

Before proceeding with deprecation:

  1. Analyze current usage patterns of defaultAddonsToRemove
    • Identify how users are utilizing the selective removal capability
    • Determine if there are common patterns that would be broken by moving to an all-or-nothing approach
  2. Evaluate potential migration paths for users who need selective addon removal
  3. Consider if we need to maintain both options or if AWS's solution sufficiently covers all use cases

References

@flostadler flostadler added the kind/enhancement Improvements or new features label Nov 12, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@flostadler flostadler added service/eks EKS issues and removed needs-triage Needs attention from the triage team labels Nov 12, 2024
@t0yv0
Copy link
Member

t0yv0 commented Nov 12, 2024

There was some pushback on #3009 before but I think what was missing is allowing users to still not get the addons wihch is now made available with bootstrapSelfManagedAddons. Thanks for filing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features service/eks EKS issues
Projects
None yet
Development

No branches or pull requests

3 participants