Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pulumi-terraform-bridge to v3.63.1 #247

Closed
wants to merge 3 commits into from

Conversation

pulumi-bot
Copy link
Contributor

This PR was generated via $ upgrade-provider pulumi/pulumi-confluentcloud --kind=bridge --target-bridge-version=v3.63.1 --pr-reviewers=t0yv0 --pr-description=.


  • Upgrading pulumi-terraform-bridge from v3.60.1 to v3.63.1.

@pulumi-bot pulumi-bot self-assigned this Oct 25, 2023
@pulumi-bot pulumi-bot requested a review from t0yv0 October 25, 2023 18:35
@pulumi-bot pulumi-bot enabled auto-merge (squash) October 25, 2023 18:35
@github-actions
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe added impact/no-changelog-required This issue doesn't require a CHANGELOG update and removed needs-triage Needs attention from the triage team labels Oct 26, 2023
@t0yv0
Copy link
Member

t0yv0 commented Oct 26, 2023

 TypeError: __init__() got multiple values for argument 'resource_name'
  
  Resources:
      + 11 to create
  

@t0yv0
Copy link
Member

t0yv0 commented Oct 26, 2023

Something is not quite right with the latest version.

@justinvp
Copy link
Member

Summary of the problem:

The KafkaAcl resource accepts a resourceName input property.

When projected into the resource's __init__ in python, it is resource_name_ with the _ suffix, so that it doesn't conflict with the standard resource_name arg that all python resources accept for the Pulumi resource name:

Standard resource_name arg:

Input property resource_name_ with _ suffix:

resource_name_: Optional[pulumi.Input[str]] = None,

And this is how resource_name_ passed to RegisterResource:

__props__.__dict__["resource_name"] = resource_name_

The KafkaAclArgs class on the other hand, doesn't have to use the _ suffix for resource_name, because it doesn't otherwise have a conflicting resource_name arg:

The problem comes in with the introduction of _configure on KafkaAclArgs. It's expecting a resource_name keyword argument, but typically resource_name isn't specified by keyword. In the example in this repo, it's just the first positional arg:

confluent.KafkaAcl(name,

And the resource_name_ won't be properly passed through to _configure, because it's looking for a resource_name keyword argument, not resource_name_.

So anyway, upgrading to v3.91.1 pulumi codegen will get rid of _configure, and the misguided a0b6195 commit in this PR is not necessary. The example should remain setting resource_name_ with the _ suffix.

@iwahbe iwahbe closed this Oct 28, 2023
auto-merge was automatically disabled October 28, 2023 16:21

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants