Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing resource properties by their IDs #1488

Open
flostadler opened this issue Nov 13, 2024 · 1 comment
Open

Allow passing resource properties by their IDs #1488

flostadler opened this issue Nov 13, 2024 · 1 comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@flostadler
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently the components in this provider accept multiple inputs that are pulumi resources. For example an aws.iam.InstanceProfile for NodeGroup & NodeGroupV2.

This complicates passing dependencies across stacks or using constants for known properties and forces users to centralize their configuration or use .get functions for retrieving handles for resources.

The bug pulumi/pulumi#17515 complicates this scenario even further because the results of .get fail to be passed across component boundaries in nodejs.

To simplify the API, we should introduce scalar properties for all resources. E.g. a string input property called instanceProfileName for the instance profile.

Affected area/feature

  • Component Inputs
@flostadler flostadler added impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features labels Nov 13, 2024
@jdavredbeard
Copy link
Contributor

#1497 adds instanceProfileName to NodeGroupBaseOptions
Remaining component args that need scalar properties added include:

NodeGroupBaseOptions:
- extraNodeSecurityGroups?: aws.ec2.SecurityGroup[];

ClusterOptions
- instanceRole?: pulumi.Input<aws.iam.Role>;
- serviceRole?: pulumi.Input<aws.iam.Role>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants