Update upload-artifact and download-artifact actions (#1383)

v3 of `actions/upload-artifact` and `actions/download-artifact` will be
deprecated on November 30, 2024. This commit bumps the versions of these
actions to v4. While there are breaking changes between v3 and v4
(namely, the introduction of immutable artifacts), it doesn't appear
that `pulumi-java` falls foul of them, so this is hopefully as simple as
bumping the version.

.github/workflows/pr.yml

@@ -83,11 +83,11 @@ jobs:
       - run: make build_go
       - run: make bin/pulumi-java-gen
       - run: make bin/pulumi-language-java
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: versions.txt
           path: versions.txt
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: go-binaries
           path: bin/
@@ -96,7 +96,7 @@ jobs:
         with:
           arguments: publishToMavenLocal
           build-root-directory: sdk/java
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: java-sdk
           path: ~/.m2/repository/com/pulumi
@@ -135,7 +135,7 @@ jobs:
         with:
           go-version: stable
       - name: Download go-binaries
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: go-binaries
           path: ~/bin
@@ -144,7 +144,7 @@ jobs:
           chmod a+x ~/bin/pulumi-language-java
           chmod a+x ~/bin/pulumi-java-gen
       - name: Download versions.txt
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: versions.txt
           path: artifacts
@@ -172,7 +172,7 @@ jobs:
               ${{ steps.go-cache-paths.outputs.go-mod }}
           key: go-cache-test-go-${{ hashFiles('**/go.sum') }}
       - name: Download Java SDK
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: java-sdk
           path: ~/.m2/repository/com/pulumi
@@ -232,14 +232,14 @@ jobs:
       - name: Install Pulumi CLI
         uses: pulumi/actions@v4
       - name: Download versions.txt
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: versions.txt
           path: artifacts
       - name: Setup versioning env vars
         run: cat artifacts/versions.txt | tee $GITHUB_ENV
       - name: Download Java SDK
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: java-sdk
           path: ~/.m2/repository/com/pulumi
@@ -344,14 +344,14 @@ jobs:
       - name: Install Pulumi CLI
         uses: pulumi/action-install-pulumi-cli@v2
       - name: Download versions.txt
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: versions.txt
           path: artifacts
       - name: Setup versioning env vars
         run: cat artifacts/versions.txt | tee $GITHUB_ENV
       - name: Download Java SDK
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: java-sdk
           path: ~/.m2/repository/com/pulumi
@@ -397,14 +397,14 @@ jobs:
               ${{ steps.go-cache-paths.outputs.go-mod }}
           key: go-cache-templates-${{ hashFiles('**/go.sum') }}
       - name: Download versions.txt
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: versions.txt
           path: artifacts
       - name: Setup versioning env vars
         run: cat artifacts/versions.txt | tee $GITHUB_ENV
       - name: Download Java SDK
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: java-sdk
           path: ~/.m2/repository/com/pulumi
@@ -435,4 +435,4 @@ jobs:
           ARM_CLIENT_SECRET: ${{ secrets.ARM_CLIENT_SECRET }}
           ARM_SUBSCRIPTION_ID: ${{ secrets.ARM_SUBSCRIPTION_ID }}
           ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}
-        run: make test_templates
+        run: make test_templates