Build failing with error: malformed HTML
#1408
Assignees
Labels
impact/regression
Something that used to work, but is now broken
kind/bug
Some behavior is incorrect or out of spec
p1
A bug severe enough to be the next item assigned to an engineer
Milestone
Comments
iwahbe
added
impact/regression
justinvp
added
p1
lunaris
added a commit
that referenced
this issue
Aug 13, 2024
When formatting Javadocs, we use a state machine to track what we should be
escaping and when. In the case of non-code blocks, we generally HTML-escape all
characters except `@`, which must be encoded using a Javadoc `{@literal @}`
block. If we see a sequence of `@` characters, we enter a state where we try to
print as many `@`s as possible before closing the `@literal` block.
Unfortunately, there is a bug whereby when closing the literal block (because we
have seen a non-`@` character), we do not HTML-escape the first character after
it. This commit fixes this issue.
Fixes #1408
lunaris
added a commit
that referenced
this issue
Aug 13, 2024
When formatting Javadocs, we use a state machine to track what we should be
escaping and when. In the case of non-code blocks, we generally HTML-escape all
characters except `@`, which must be encoded using a Javadoc `{@literal @}`
block. If we see a sequence of `@` characters, we enter a state where we try to
print as many `@`s as possible before closing the `@literal` block.
Unfortunately, there is a bug whereby when closing the literal block (because we
have seen a non-`@` character), we do not HTML-escape the first character after
it. This commit fixes this issue.
Fixes #1408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Example
This was discovered when testing pulumi-terraform-bridge v3.89.0-candidate on docker:
https://github.com/pulumi/pulumi-docker/actions/runs/10307662375/job/28533381889
I have confirmed that this issue is not present on 0.12.0.
Output of
pulumi aboutNA
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: