Bump default gradle-nexus.publish-plugin version
#1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
requested review from
t0yv0 and
a team
and removed request for
a team
lunaris
approved these changes
Nov 20, 2024
CHANGELOG.md
Outdated
| ### Improvements | ||
|
|
||
| - Update `io.github.gradle-nexus.publish-plugin` to 2.0.0 from 1.1.0. | ||
|
|
There was a problem hiding this comment.
If you add this to CHANGELOG_PENDING it gets taken care of for you as part of the release process.
There was a problem hiding this comment.
My kingdom for a consistent changelog process :)
t0yv0
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I have some hesitation with respect to this dependency so I hope we tried running it at least once to see it produces the releases and does not require changes from our SDK gen setup (2.0 might be breaking after all) before rolling out here. But otherwise LGTM :)
blampe
added a commit
to pulumi/pulumi-command
that referenced
this pull request
Nov 20, 2024
This is a sanity check to ensure Java publishing still works `io.github.gradle-nexus.publish-plugin` v2. Refs pulumi/pulumi-java#1479.
|
@t0yv0 of course -- https://github.com/pulumi/pulumi-command/actions/runs/11942352524/job/33292492882 seems there was a flake but it eventually succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes.
We don't use this option, so this shouldn't impact us.
Refs https://github.com/pulumi/home/issues/3762.