Don't generate incorrect code for MultiArgSigs
#1598
Labels
Comments
lunaris
added
area/codegen
lunaris
added a commit
that referenced
this issue
Jan 17, 2025
Presently, Java code generation does not support the `MultiArgumentInputs` field on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of: ```java Class.function(FunctionArgs.build().setA(a).setB(b).build()); ``` we might generate: ```java Class.function(a, b); ``` Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if `MultiArgumentInputs` is true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature). Fixes #1598
lunaris
added a commit
that referenced
this issue
Jan 17, 2025
Presently, Java code generation does not support the `MultiArgumentInputs` field on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of: ```java Class.function(FunctionArgs.build().setA(a).setB(b).build()); ``` we might generate: ```java Class.function(a, b); ``` Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if `MultiArgumentInputs` is true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature). Fixes #1598
lunaris
added a commit
that referenced
this issue
Jan 17, 2025
Presently, Java code generation does not support the `MultiArgumentInputs` field on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of: ```java Class.function(FunctionArgs.build().setA(a).setB(b).build()); ``` we might generate: ```java Class.function(a, b); ``` Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if `MultiArgumentInputs` is true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature). Fixes #1598
lunaris
added a commit
that referenced
this issue
Jan 17, 2025
Presently, Java code generation does not support the `MultiArgumentInputs` field on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of: ```java Class.function(FunctionArgs.build().setA(a).setB(b).build()); ``` we might generate: ```java Class.function(a, b); ``` Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python). Currently, however, Java does not, proceeding instead to generate incorrect code. This change fixes that, panicking if `MultiArgumentInputs` is true. This is technically breaking, but a bug fix (and in theory, any SDKs we have generated would already be panicking for Python, so the feeling is that this likely not a highly used feature). Fixes #1598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presently, Java code generation does not support the
MultiArgumentInputsfield on invokes. When set, this flag instructs the generation of functions that take multiple independent arguments instead of a single object containing all arguments. For example, instead of:we might generate:
Since it is not supported, the correct behaviour is to panic and abort code generation, as we do in other languages with this limitation (e.g. Python).
The text was updated successfully, but these errors were encountered: