Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PulumiPluginJSON.Server in pulumi-java-gen #711

Open
t0yv0 opened this issue Jun 29, 2022 · 1 comment
Open

Support PulumiPluginJSON.Server in pulumi-java-gen #711

t0yv0 opened this issue Jun 29, 2022 · 1 comment
Labels
area/plugins kind/enhancement Improvements or new features size/S Estimated effort to complete (1-2 days).

Comments

@t0yv0
Copy link
Member

t0yv0 commented Jun 29, 2022

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

With #709 the responsibility of generating plugin.json with metadata about the package is moving from pulumi-java-gen invocation itself to the generated build system, currently supporting Gradle. One feature lost in translation is populating the server field from PluginDowlnoadURL in the schema.

That is on the old path we have:

		pulumiPlugin := &plugin.PulumiPluginJSON{
			Resource: true,
			Name:     pkg.Name,
			Version:  cfg.Version.String(),
			Server:   pkg.PluginDownloadURL,
		}

We should have the same functionality on the new path. pulumi-java-gen should emit build code that populates PluginDownloadURL from the schema to the generated Java resource plugin.json so the generated SDK code can read it back and act accordingly.

Affected area/feature

@t0yv0 t0yv0 added kind/enhancement Improvements or new features size/S Estimated effort to complete (1-2 days). labels Jun 29, 2022
@muhlba91
Copy link

muhlba91 commented Jun 7, 2023

related to #1109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement Improvements or new features size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

No branches or pull requests

3 participants