Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow failure: main #233

Closed
pulumi-bot opened this issue Dec 16, 2024 · 5 comments · Fixed by #238
Closed

Workflow failure: main #233

pulumi-bot opened this issue Dec 16, 2024 · 5 comments · Fixed by #238
Assignees
@guineveresaenger
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Dec 16, 2024 •
edited
Loading

Workflow Failure

main has failed. See the list of failures below:
@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Dec 16, 2024
@guineveresaenger
Copy link
Contributor

It looks like #234 was automerged without tests passing?

@guineveresaenger guineveresaenger self-assigned this Dec 17, 2024
@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label Dec 17, 2024
@guineveresaenger
Copy link
Contributor

Related: #235

Same tests are failing.

@guineveresaenger
Copy link
Contributor

Alright, I ran the test program locally and could reproduce the bug. It's a permadiff, and I believe comes from upstream.

When attempting to run this program in Terraform, this became far more obvious, because of Terraform's different diff checking mechanism.

I filed Juniper/terraform-provider-mist#66 upstream.

I will skip the two affected tests that use the resource in question and file a followup issue to un-skip once upstream is fixed.

@guineveresaenger guineveresaenger mentioned this issue Dec 17, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 18, 2024
@guineveresaenger
Copy link
Contributor

final update: I also enabled branch protection, not allowing a merge unless Sentinel passes.

@pulumi-bot
Copy link
Contributor Author

This issue has been addressed in PR #238 and shipped in release v0.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip wlan examples due to upstream permadiff pulumi/pulumi-junipermist
2 participants
@guineveresaenger @pulumi-bot