Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noisy diff in Webhook resource, when secret is provided #369

Closed
IaroslavTitov opened this issue Aug 6, 2024 · 2 comments
Closed

Noisy diff in Webhook resource, when secret is provided #369

IaroslavTitov opened this issue Aug 6, 2024 · 2 comments
Assignees
@IaroslavTitov
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.113

Comments

@IaroslavTitov
Copy link
Contributor

What happened?

Secret value is not returned for Webhooks via pulumi API. We need to implement the same refresh handling as DeploymentSettings for this one.

Example

  • Create a Webhook with secret
  • Run pulumi refresh

Output of pulumi about

Not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@IaroslavTitov IaroslavTitov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 6, 2024
@IaroslavTitov IaroslavTitov self-assigned this Aug 6, 2024
@IaroslavTitov IaroslavTitov removed the needs-triage Needs attention from the triage team label Aug 6, 2024
@IaroslavTitov IaroslavTitov added this to the 0.109 milestone Aug 6, 2024
@komalali komalali modified the milestones: 0.109, 0.111 Sep 12, 2024
@komalali komalali modified the milestones: 0.111, 0.112 Oct 24, 2024
@komalali komalali modified the milestones: 0.112, 0.113 Nov 10, 2024
@IaroslavTitov IaroslavTitov added the resolution/fixed This issue was fixed label Nov 14, 2024
@IaroslavTitov
Copy link
Contributor Author

Completed in #440

@pulumi-bot
Copy link

This PR has been shipped in release v0.27.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IaroslavTitov IaroslavTitov

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.113
Development

No branches or pull requests
3 participants
@IaroslavTitov @komalali @pulumi-bot