Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitlab-cy.yml missing in pdk-templates 3.0? #524

Open
drakpzone opened this issue Jul 10, 2023 · 6 comments
Open

.gitlab-cy.yml missing in pdk-templates 3.0? #524

drakpzone opened this issue Jul 10, 2023 · 6 comments

Comments

@drakpzone
Copy link

Use Case

previous versions of PDK and pdk-templates used to provide a minimal (albeit functional) .gitlab-ci.yml, but apparently that's not the case with pdk templates v3.0. I was also hoping that a pdk upgrade would upgrade the existing .gitlab-ci.yml and drop the usage of puppet 6 for CI.

Describe the Solution You Would Like

Get back previous .gitlab-ci.yml with puppet 7 and 8 as default

@cruelsmith
Copy link

Mhm, it has been removed with #510 since puppetlabs do not use it. But i would had been expected that this would have been at least mentioned in the release notes for pdk.

Im also now need to manually maintain the .gitlab-ci.yml for my gitlab projects 😢

@silug
Copy link
Contributor

silug commented Jul 17, 2023

Mhm, it has been removed with #510 since puppetlabs do not use it. But i would had been expected that this would have been at least mentioned in the release notes for pdk.

I agree. It's really odd that a large change like that was made with no mention in the release notes.

@Tamerz
Copy link

Tamerz commented Jul 27, 2023

I would also like this back if possible.

@cruelsmith
Copy link

JFYI: Here is my updated version of .gitlab-ci.yaml for PDK 3 feel free to use and/or to readd it here again. https://gist.github.com/cruelsmith/3a5214730d1abb1ec4ebd3d01215c89f

@mattatnersc
Copy link

I understand why they would remove it (it is hard to maintain something you don't use), but our org uses gitlab, so I'd like it back.

kenyon added a commit to kenyon/puppet that referenced this issue Aug 24, 2023
PDK update didn't update this because it was removed from PDK
templates.

* puppetlabs/pdk-templates#524
* puppetlabs/pdk-templates@89b3a9a
@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 23, 2024

Hey everyone we are listening to you all and your input on the following discussion would be invaluable! #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants