Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bolt 4.x #529

Merged
merged 1 commit into from
Dec 12, 2024
+1 −1
Merged

Add support for bolt 4.x #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/assert_supported_bolt_version.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
function peadm::assert_supported_bolt_version (
# No arguments
) >> Struct[{ 'supported' => Boolean }] {
$supported_bolt_version = '>= 3.17.0 < 4.0.0'
$supported_bolt_version = '>= 3.17.0 < 5.0.0'
Copy link
Member

@ragingra ragingra Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version in the gem file as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that before raising the PR, the Gemfile doesn't pin the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is still pulling in v3.x of the bolt gem because of the puppet_litmus dependency. We're working on getting that updated ASAP.

If that can't be done in the next few days I've got a workaround we can add so that we're testing against Bolt 4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litmus updated for bolt4 now. Closing and reopening to rekick CI

$supported = (peadm::bolt_version() =~ SemVerRange($supported_bolt_version))
# lint:ignore:strict_indent
unless $supported {
Expand Down
Loading