Allow empty string value for config entries #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaflos
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
|
I don't think I can do anything about the failing tests (labeller and mend). The rest looks good. |
|
@bastelfreak Will do. Our use case for empty strings here is that we have applications that use transaction-bound session variables, as in PostgreSQL 13 (and possibly newer versions also) requires such session variables to be defined beforehand and initialised with a default value, such as the empty string, in postgresql.conf. |
PostgreSQL supports and allows config entries, such as those in postgresql.conf, to be set to the empty string. The `postgresql::server::config_entry` defined type, however, requires String[1] when supplying string values. This doesn't allow for the empty string. This change relaxes the allowed data types for the `value` parameter of `postgresql::server::config_entry` to `String` from `String[1]` and adds a spec test to support the change. Fixes puppetlabs#1602
antaflos
force-pushed
the
config_allow_empty_values
branch
from
263eaab
to
6cb0f1f
Compare
bastelfreak
approved these changes
Aug 14, 2024
deric
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL supports and allows config entries, such as those in postgresql.conf, to be set to the empty string. The
postgresql::server::config_entrydefined type, however, requires String[1] when supplying string values. This doesn't allow for the empty string.This change relaxes the allowed data types for the
valueparameter ofpostgresql::server::config_entrytoStringfromString[1]and adds a spec test to support the change.Related Issues (if any)
#1602
Checklist
puppet apply)