Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying a text transformation in the Styles parameter causes unrelated text- styles to be dropped #70

Open
codymullins opened this issue May 8, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@codymullins
Copy link
Contributor

codymullins commented May 8, 2024

Describe the bug
Passing a text style, e.g. text-sm, will cause other unrelated styles to disappear, e.g. text-brand-800.

To Reproduce
This can be reproduced by viewing the PureBreadcrumbItem:

<PureBreadcrumb>
    <PureBreadcrumbItem Href="/sites" Name="Sites"/>
    <PureBreadcrumbItem Href="/sites/1" Name="Site 1"/>
    <PureBreadcrumbItem Name="Page"/>
</PureBreadcrumb>

Expected behavior
The PureBreadcrumbItem should have a smaller size, but retain the color applied via the style.

Screenshots

normal usage:
image

using text-sm:
image

Additional context

  • This likely stems from the StylePrioritizer and KeyExtractor.ToCssKey(...)
  • Need to confirm if this affects other style keys
@codymullins codymullins added bug Something isn't working help wanted Extra attention is needed labels May 8, 2024
@codymullins
Copy link
Contributor Author

similar issue effects applying bg-white as the Style in PureHeader: both bg-brand-800 and bg-white are applied to the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant