Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrapped versions of DOM components #16

Open
paluh opened this issue Dec 29, 2020 · 1 comment
Open

Unwrapped versions of DOM components #16

paluh opened this issue Dec 29, 2020 · 1 comment

Comments

@paluh
Copy link

paluh commented Dec 29, 2020

Thanks again for building react-basic!

Currently this library provides bindings to DOM components but wraps it in ref forwarding and processes aria and data props in the constructor. This breaks compatibility with libs like helmet where the tool expects native components (it checks child.type against a set of tag names like title, meta etc.).

Would you be so kind and tell me if you think that an addition of something like DOM.Unwrapped which provides components based on a simple unsafeCreateDOMComponent tagName = unsafeCoerce tagName without ref forwarding and props processing is a good idea?

@megamaddu
Copy link
Member

Yeah, that seems reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants