Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[push notifications] Error callbacks? #239

Open
dingbat opened this issue Nov 24, 2016 · 3 comments
Open

[push notifications] Error callbacks? #239

dingbat opened this issue Nov 24, 2016 · 3 comments

Comments

@dingbat
Copy link

dingbat commented Nov 24, 2016

Hi,

What's the plan on providing error callbacks via the delegate to PTNativePusher methods like registerWithDeviceToken, subscribe, and unsubscribe? I noticed right now it's just printing to the console, but this isn't helpful for a production app :)

Let me know if someone is working on it already or if it's tricky for some reason, but I'm willing to help out with it.

Thanks

@hamchapman
Copy link
Contributor

Nothing particularly hard about it! Feel free to make a PR if you're up for it 👍

I've just made one for the Swift library (which works with Objective-C) here: pusher/pusher-websocket-swift#111

@dingbat
Copy link
Author

dingbat commented Nov 25, 2016

That's great, thank you! In general Is the Swift library the one to use going forward since it also supports Obj-C?

@hamchapman
Copy link
Contributor

No problem!

And yeah, we're definitely going to be quicker to add new features and fix bugs on the Swift library 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants