For SSR compatibility, add CJS build and guard global variable access #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #624
What does this PR do?
For compatibility with frameworks like NextJS that do server-side rendering, fix two things:
import Pusher from 'pusher-js/cjs'
orimport Pusher from 'pusher-js/cjs/with-encryption'
window
anddocument
are not accessed in server environments, where they don't exist.These two changes allow SSR framework users to import Pusher with a reasonably industry-standard DX, without breaking their apps or resorting to dynamic imports.
Checklist
npm run format
has been runCHANGELOG