Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debugger] Accessing createClass via the main React package is deprecated #39

Open
ksloan opened this issue Sep 14, 2017 · 4 comments · May be fixed by #40
Open

[Debugger] Accessing createClass via the main React package is deprecated #39

ksloan opened this issue Sep 14, 2017 · 4 comments · May be fixed by #40

Comments

@ksloan
Copy link

ksloan commented Sep 14, 2017

It looks like this was fixed in #32, but the debugger was never fixed.

Specifically it's complaining about this line https://github.com/pushtell/react-ab-test/blob/master/lib/debugger.js#L97

ie. https://github.com/pushtell/react-ab-test/blob/master/src/debugger.jsx#L81
@okovpashko okovpashko linked a pull request Sep 25, 2017 that will close this issue
Open
8 tasks
@ksloan
Copy link
Author

ksloan commented Sep 26, 2017

I realize you're working on this, but it's crashing React 16.0 now.

@okovpashko
Copy link

@ksloan it's an expected behavior. Deprecation warnings in React v15.5 and v15.6 become errors in React v16. I've created a PR, but it's waiting to be checked and merged by the contributors.

@peterpme @wehriam could you please check the PR and merge it?

@kjs3
Copy link

kjs3 commented Jun 27, 2018

@peterpme, @wehriam: Is there an issue with @okovpashko's PR?

@philals
Copy link

philals commented Jul 6, 2018

FYI - moretti has forked waiting pending PRs/new maintainers(?): https://github.com/marvelapp/react-ab-test

Here's another thread: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Debugger from React.createClass to ES6 class okovpashko/react-ab-test
4 participants
@kjs3 @ksloan @okovpashko @philals