Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Password Generator options #687

Open
4 tasks done
Robin481 opened this issue Apr 17, 2023 · 1 comment · May be fixed by #703
Open
4 tasks done

More Password Generator options #687

Robin481 opened this issue Apr 17, 2023 · 1 comment · May be fixed by #703
Assignees

Comments

@Robin481
Copy link
Member

Robin481 commented Apr 17, 2023

Instead of just having the option for a random password that is always 14 characters long we would like to have it more configurable.

Options should be:

  • Length of the randomly generated password (up until 32 characters)
  • Whether the password contains special characters or not

Additionally we should evaluate whether we are using a proper random generator or if we should switch to something more secure. From a short glimpse we use Math.random which according to: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/random should not be used for anything security related.

ToDo:

  • Draw a Mockup for the design to make it clear how it should look when it is done
    • Check with UX/The team whether this seems reasonable
  • Replace Math.random with something secure like https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues
  • Create the inputs that allow the user to determine which options are selected when creating the random password.
  • Tests 🥳
@Vakmeth Vakmeth assigned Vakmeth and kcinay055679 and unassigned Vakmeth May 9, 2023
@kcinay055679 kcinay055679 removed their assignment May 22, 2023
@njaeggi njaeggi assigned njaeggi and unassigned njaeggi May 22, 2023
@Vakmeth Vakmeth assigned Vakmeth and kcinay055679 and unassigned Vakmeth May 22, 2023
@kcinay055679 kcinay055679 linked a pull request May 30, 2023 that will close this issue
@kcinay055679
Copy link
Collaborator

kcinay055679 commented Jun 5, 2023

Blocked by #707

@Vakmeth Vakmeth assigned Vakmeth and unassigned Vakmeth Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants