Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: email attr before password #753

Open
njaeggi opened this issue Sep 26, 2023 · 1 comment
Open

FEATURE: email attr before password #753

njaeggi opened this issue Sep 26, 2023 · 1 comment

Comments

@njaeggi
Copy link
Contributor

njaeggi commented Sep 26, 2023

Since the implementation of Custom Attrs, emails can also be saved to cryptopus. Custom Attrs currently uses the password before the email, that leads to this behavior

image

To me that doesn't really make sense, the email should be before the password, only problem then is that when you set username and email, the password wont be displayed in the row component.... since its only two fields per credential

image

In the show view, email is already displayed before the password.

I would recommend to include email before password everywhere, the current behavior could get really confusing, since most cryptopus users always expect the password to be on the right (2nd set attr)

image

Note:
While implementing custom attrs we already talked about this and the conclusion was that username/password are the two default attrs, that's why they are still the first two, before email :)

@kcinay055679
Copy link
Collaborator

@njaeggi i got the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants