Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Turbo 8 #752

Closed
Robin481 opened this issue Jul 25, 2024 · 2 comments · Fixed by #802
Closed

Upgrade to Turbo 8 #752

Robin481 opened this issue Jul 25, 2024 · 2 comments · Fixed by #802
Assignees
@RandomTannenbaum
Labels
enhancement New feature or request plan needs to be planned

Comments

@Robin481
Copy link
Member

Robin481 commented Jul 25, 2024 •
edited
Loading

https://jbennett.me/articles/turbo-8-upgrade-guide/

The new "on-hover-of-link-load-the-next-page" looks amazing... We want that 😁

TODO:

  • Upgrade Gem to its newest version (this by itself does not upgrade to Turbo 8)
  • Upgrade the @hotwired/turbo-rails package to a version greater than 8
  • Make sure all the tests still run 🔢
  • Disable in development
@Robin481 Robin481 added enhancement New feature or request plan needs to be planned labels Jul 25, 2024
@Robin481 Robin481 mentioned this issue Jul 30, 2024
Open
@RandomTannenbaum RandomTannenbaum self-assigned this Feb 17, 2025
@RandomTannenbaum
Copy link
Collaborator

RandomTannenbaum commented Feb 17, 2025 •
edited
Loading

ToDo

  • Upgrade turbo-rails gem and npm package to version 8
  • Run tests
  • Disable link preloading in development environment
  • Review

@RandomTannenbaum RandomTannenbaum linked a pull request Feb 17, 2025 that will close this issue
Upgrade turbo-rails to v8 #802
Merged
@RandomTannenbaum
Copy link
Collaborator

Stand 19.02.2025
Turbo ist jetzt auf der neusten Version, die Tests laufen durch. Zusätzlich habe ich noch einen kleinen bug behoben, durch den das scroll-to Seitenmenu auf der skills Ansicht einer Person nicht funktioniert hat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RandomTannenbaum RandomTannenbaum

Labels
enhancement New feature or request plan needs to be planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade turbo-rails to v8 puzzle/skills
2 participants
@Robin481 @RandomTannenbaum