Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Buttons and Dropdowns Turbo 8 friendly #755

Open
Robin481 opened this issue Jul 30, 2024 · 2 comments
Open

Make Buttons and Dropdowns Turbo 8 friendly #755

Robin481 opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
plan needs to be planned

Comments

@Robin481
Copy link
Member

Robin481 commented Jul 30, 2024

Depends on this being completed: #752

Turbo 8 adds Link-Preloading. This works perfecty fine for normal links but not for e.g. The People dropdown because those probably aren't normal links. Some dropdown libraries have a option to display the elements as links. Maybe ours has that.

TODO:

  • Check which buttons, dropdowns or actual links that don't work with Link-Preloading yet
  • Try to fix as many of those wherever possible
  • Make sure performance doesn't become an issue (e.g. In the People Dropdown scrolling over "all" the people when looking through the list will then send a request each which might be a bit too much)
@Robin481 Robin481 added the plan needs to be planned label Jan 27, 2025
@RandomTannenbaum RandomTannenbaum self-assigned this Feb 21, 2025
@RandomTannenbaum
Copy link
Collaborator

ToDo

  • Check links in application and document which do not work yet with link preloading -> especially check slim select dropdowns
  • Fix those that are possible
  • Smoke Test
  • Review

@RandomTannenbaum
Copy link
Collaborator

RandomTannenbaum commented Feb 21, 2025

ToDo

  • Find good timeout for link prefetching in people dropdown
  • Check possibilities for prefetching on-focus
  • Check performance impact on server
  • Fix language selection
  • Re-disable link prefetching in dev before merging ticket
  • Update version number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan needs to be planned
Projects
None yet
Development

No branches or pull requests

2 participants