Generate a Favicon by Default #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will address issue #3 and #4.
I'm really sorry this is my first pull request, I know not to merge from master now.
Some commits are just one or two lines of change so it looks like I did much more.
Using favicons and toIco favicon files of 16x16, 32x32, 48x48 are created.
The files are then layered into a single .ico file and deleted, creating a favicon,ico file in the src folder by default.
-foor--faviconOutputmay be used to change the default output directory.If a .jpg is used the user is notified of this feature in case they would like to take advantage of it.