Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use progress bars as charts #40

Closed
michaelwood opened this issue Oct 29, 2019 · 0 comments · Fixed by #59
Closed

Don't use progress bars as charts #40

michaelwood opened this issue Oct 29, 2019 · 0 comments · Fixed by #59
Assignees
@michaelwood
Labels
December 2021

Comments

@michaelwood
Copy link
Collaborator

When tests have run the progress bars which are used to represent the results e.g. "Project attributes: 89% pass" just look like the tests themselves are still loading. This has caused confusion for some users.

Related issue #18
michaelwood added a commit that referenced this issue Dec 14, 2021
@michaelwood
templates: progress-bars: Improve readability of result charts
18d9660 
* Create better visual distinction between a progress bar and a chart to
avoid confusion
* Show the failed portion of the chart in matching colour with reduced
opacity rather than black
* Add tooltip texts on overview graphs
* Add explanation text in overview of what is being shown

Fixes: #40
@michaelwood michaelwood mentioned this issue Dec 14, 2021
Merged
Lathrisk pushed a commit that referenced this issue Dec 16, 2021
@michaelwood
templates: progress-bars: Improve readability of result charts
73ce3b9 
* Create better visual distinction between a progress bar and a chart to
avoid confusion
* Show the failed portion of the chart in matching colour with reduced
opacity rather than black
* Add tooltip texts on overview graphs
* Add explanation text in overview of what is being shown

Fixes: #40
@Lathrisk Lathrisk linked a pull request Dec 16, 2021 that will close this issue
templates: progress-bars: Improve readability of result charts #59
Merged
Lathrisk pushed a commit that referenced this issue Dec 17, 2021
@michaelwood
templates: progress-bars: Improve readability of result charts
65bec08 
* Create better visual distinction between a progress bar and a chart to
avoid confusion
* Show the failed portion of the chart in matching colour with reduced
opacity rather than black
* Add tooltip texts on overview graphs
* Add explanation text in overview of what is being shown

Fixes: #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelwood michaelwood

Labels
December 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

templates: progress-bars: Improve readability of result charts pwyf/data-quality-tester
2 participants
@michaelwood @Lathrisk