-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Drop Python3.8 support #1056
Conversation
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
The test pipeline will have to be fixed as well, as it currently tries to run all the testcases for python 3.8 |
This PR is stale because it has been open for 60 days with no activity. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
@adam2392 will you be able to edit the test pipeline? Shall we also support python 3.12 since that is a stable release now? |
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Done @amit-sharma |
Signed-off-by: Adam Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note whoever is the owner of "ghcr.io/${{ github.repository_owner }}/dowhy-docs-generation:latest"
needs to update the container to use Python3.8+
Preferably Python3.11, since that will future proof the CI and it's just doc building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. @petergtz I remember you had set this up? can you update the python version as Adam suggests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam2392 @amit-sharma Hey guys, the image referred to by Adam is built using the build-docker-image-docs.yml workflow. The Dockerfile it refers to is docs/Dockerfile.
This Dockerfile builds on top of another Docker image (ghcr.io/py-why/dowhy-example-notebooks-deps
) where the actual installation of packages happens. You can find its Dockerfile in py-why/dowhy-example-notebooks-deps-dockerfile.
If you want to bump the Python version, it should probably happen there. I wouldn't know from the top of my mind how to do it though, as we're never explicitly specifying the Python version. Maybe using a newer Ubuntu base image could do, but unsure. Also have a look at the README, it says that the R dependencies are really difficult to control. Maybe you can delete all these dependencies now, because there is no R code anymore. Otherwise, you'll probably have to go through some trial and error.
Signed-off-by: Adam Li <[email protected]>
This PR is stale because it has been open for 60 days with no activity. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Fixes: #1055
This is to just demonstrate what would need to be fixed.