Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate over dodiscover CI/CD tests #5

Open
adam2392 opened this issue Apr 5, 2023 · 1 comment
Open

Migrate over dodiscover CI/CD tests #5

adam2392 opened this issue Apr 5, 2023 · 1 comment

Comments

@adam2392
Copy link
Collaborator

adam2392 commented Apr 5, 2023

Systematically migrate independence test, documentation and unit tests one at a time.

@adam2392
Copy link
Collaborator Author

adam2392 commented Apr 10, 2023

Suite of tests we should migrate over from dodiscover are:

  • Chi-square
  • G^2 (note there might be discrepancies between G^2 implementation vs Chi-square general approach)
  • FisherZ (i.e. partial correlation)
  • KernelCI
  • ClassifierCI
  • RegressionCI
  • ClassifierCMICI
  • CMICI
  • Oracle
  • KernelCD
  • Bregman

Along the way, Monte Carlo and kernel utility functions should be ported.

Simulation functions that help test the code should also be added here since those don't require the input of a graph:

  • nonlinear_additive_gaussian

Also the test data should be moved here:

  • testdata.py for G^2 implementation
  • adult.csv for Chi-square

From dowhy: @bloebp can start moving over tests too and consolidating with the above list where applicable.

Once done, we can also compare implementations vs causal-learn and then migrate any improvements that are there but not in the above implementations (if any), and then fully remove CI/CD tests in general and create dependencies on pywhy-stats.

adam2392 added a commit that referenced this issue Apr 19, 2023
Towards #5 

Changes proposed in this pull request:
- Adds partial correlation test
- Setsup initial API design
- Includes sphinx docs

---------

Signed-off-by: Adam Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant