Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"I'm done with ptycho" -- George in August 🤦 #695

Open
wants to merge 66 commits into
base: dev
Choose a base branch
from

Conversation

gvarnavi
Copy link
Member

This PR adds a number of new features, namely:

  • virtual-detector iterative ptychography
  • slim_preprocess functionality in most (all?) ptycho classes
    • this circumvents preprocess and allows one to pass in preprocessed arrays directly
  • parallax reorganization
    • allows one to input arbitrary aberrations during initialization
    • fit aberrations recursively by radial order
    • better memory-management during upsampling
  • adds (slightly expensive) 3D Fourier-rotation in ptycho-tomo
  • adds multiprocessed direct ptychography classes
    • SSB: (phase-compensated) single-side band reconstruction
      • including recursive aberration-fitting
    • WDD: Wigner distribution deconvolution
    • OBF: optimum bright-field STEM

Will add tutorial notebooks to check/review below later today.

smribet and others added 30 commits August 30, 2024 09:24
Extending functionality to other ptycho classes
Segmented and Other Geometry Detector Ptychography
@gvarnavi
Copy link
Member Author

Updated parallax tutorials for review: updated_parallax_tutorials.zip

@gvarnavi
Copy link
Member Author

Direct ptychography tutorials for review: direct_ptychography_tutorials.zip

@gvarnavi
Copy link
Member Author

Virtual detector ptychography notebook for review: virtual_detector_ptycho_notebook.zip

@gvarnavi
Copy link
Member Author

Alrighty, this should be ready to review.

A lot of this code has been used in the wild this past month by various collaborators, so perhaps they can help us review this (I've added three sets of notebooks above to help with the review):

  • @TomaSusi -- can you have a look at the direct ptycho classes, please?
  • @kucukogluberk -- can you have a look at the parallax updates, please?
  • @juliedactyl -- can you have a look at the virtual-detector ptycho updates, please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants