Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests #12

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Add basic tests #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c247e64
add basic tests
rtimms Jun 25, 2024
6551ecc
pre-commit
rtimms Jun 25, 2024
9dc9a41
pre-commit
rtimms Jun 25, 2024
4b5136b
fix tests
rtimms Jun 25, 2024
ce989b4
update init
rtimms Jun 25, 2024
56111cc
ruff
rtimms Jun 25, 2024
19be793
fix docs build
rtimms Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pre-commit
  • Loading branch information
@rtimms
rtimms committed Jun 25, 2024
commit 6551eccc5b138663db61b5017d5be51b5a611a05
4 changes: 0 additions & 4 deletions pbeis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
from .eis_simulation import EISSimulation
from .numerical_methods import bicgstab, prebicgstab
from .plotting import nyquist_plot
from .utils import SymbolReplacer
1 change: 0 additions & 1 deletion tests/test_simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@


def test_compare_methods():

# Set up
model = pybamm.lithium_ion.SPM(options={"surface form": "differential"}, name="SPM")
parameter_values = pybamm.ParameterValues("Marquis2019")
Expand Down