-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle instance should effect instance plugins #20
Comments
In QML, what happens is that the unsupported plug-ins disappear; to only display those that actually get run/are optional. Unchecking them is a good first step, having them disappear is more complex and can come afterwards. As a detail, it should probably both uncheck and make it non-optional so the user can't check it afterwards. Running it does nothing, but it'd color it green which might be confusing. |
maybe we can just make the text gray making it look inactive instead of fully removing it? |
We could, but the benefit of hiding them is that there could be hundreds of registered plug-ins, but the user (and developer) would only ever see relevant ones. In QML, and here, I think it could be advantageous to have an option to toggle this behaviour, as it can sometimes be useful to see exactly everything that is available, for debugging purposes. |
I personally really like the hiding behavior. It makes it very clear what is about to be ran, so ultimately it would be nice to get to that eventually. |
+1 |
…o_overview feature/PYPE-376_switch_to_overview
goal
When I toggle a instance in the left hand side it should toggle on/off the relevant instance plugins on the right hand side of the overview.
implementation
A good place would be in control.py, under the on_toggle method
The text was updated successfully, but these errors were encountered: