Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI outdated #81

Open
hannesdelbeke opened this issue Dec 6, 2023 · 7 comments
Open

PyPI outdated #81

hannesdelbeke opened this issue Dec 6, 2023 · 7 comments

Comments

@hannesdelbeke
Copy link
Collaborator

pyblish-maya is outdated on pip, resulting in a bug in the latest Maya.
// Error: ModuleNotFoundError: file C:\Users/user/Documents/maya/2024/scripts\pyblish_maya\__init__.py line 1: No module named 'version'

This is already fixed however in the latest repo, see line https://github.com/pyblish/pyblish-maya/blob/893dee39aef34aa7daa7c3e5593247abb8282731/pyblish_maya/__init__.py#L1C6-L1C7

Have you considered adding a pip github action to automate updating the PyPI release?
it only takes a few miutes to setup, just copy this in the repo, and add a secret with your PYPI token

@mottosso
Copy link
Member

mottosso commented Dec 7, 2023

It used to auto-upload, but these online services keep changing. Here's the previous setup:

If you are interested in implementing this for GitHub Actions, you would be very welcome to. I've added you to the collaborator list, you should have access to actions and the repo in general now. Let me know if you need a password/hash for Actions/PyPI to perform the actual upload.

@hannesdelbeke
Copy link
Collaborator Author

sweet

I don't have permissions to add secrets., so I'll need you to create a secret:

  • go to settings in github repo
  • secrets & variables tab / actions
  • new repo secret (green button)
  • name it PYPI_API_TOKEN, and add the API token for PyPI.

@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented Dec 7, 2023

current PYPI version is 2.1.8
current github is 2.1.10

lett me know when the secret has been added and i ll release the latest one
I also hooked up the correct readme, hopefully that should show in PYPI.

@mottosso
Copy link
Member

mottosso commented Dec 9, 2023

I've added the secret now, thanks @hannesdelbeke

@hannesdelbeke
Copy link
Collaborator Author

Github added a space to the folder name so the action didn't trigger. I ll fix that

@hannesdelbeke
Copy link
Collaborator Author

The action triggered now. But there seem to be some building errors. Maybe that's why Travis didn't trigger a release ? Will need to investigate https://github.com/pyblish/pyblish-maya/actions/runs/7151457618

@mottosso
Copy link
Member

mottosso commented Dec 9, 2023

Looks like it needs Python 2.7. It's implib on Python 3. You can run setup.py locally too, to make sure it works before you make new commits. I think it's python setup.py sdist bdist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants