Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kudos to anyone removing some of type: ignore from code #25

Open
ssbarnea opened this issue Nov 15, 2020 · 0 comments
Open

Kudos to anyone removing some of type: ignore from code #25

ssbarnea opened this issue Nov 15, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Nov 15, 2020

I would greatly appreciate any pull-requests that resolve some of the huge amount of "# type: ignoreand# noqa` comments that were introduced while we enabled linting on this library.

Hint: Do not try to sort all at once, likely that even one will require a chain a of type changes so keep the scope small, so it can easily be reviewed and merged.

As the time of writing there are >160 counts of type: ignore and >240 of NOQA....

Tag me when you create the PR.

@ssbarnea ssbarnea added the help wanted Extra attention is needed label Nov 15, 2020
@ssbarnea ssbarnea pinned this issue Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant