Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTJ2K, returning bytearray #70

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Jan 4, 2024

Windows builds are broken with 2.5.0, will need to take a closer look

openjpeg\src\openjpeg\src\lib\openjp2\openjpeg.c(438): error C2491: 'opj_decoder_set_strict_mode': definition of dllimport function not allowed

@scaramallion
Copy link
Member Author

scaramallion commented Jan 4, 2024

Found the cause of the problem:

https://github.com/uclouvain/openjpeg/blob/41c25e3827c68a39b9e20c1625a0b96e49955445/src/lib/openjp2/openjpeg.c#L441

OPJ_API needs to be removed. Will need to remove it somehow during build in order to use v2.5.0 (which is required for HTJ2K)

Should create a PR against upstream to fix, too.

@scaramallion scaramallion merged commit e3c8c16 into pydicom:main Jan 4, 2024
16 of 20 checks passed
@scaramallion scaramallion deleted the dev-htj2k branch January 4, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for High Throughput JPEG2000 Update decoding interface to allow returning bytes and bytearray
1 participant