Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix LOG_REQUEST_IDENTIFIERS not applying to Associaton send QR methods #936

Merged
merged 1 commit into from
May 7, 2024

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented May 7, 2024

Reference issue

Closes #911

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (20993be) to head (ec5cb0c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #936   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8703      8706    +3     
=========================================
+ Hits          8703      8706    +3     
Files Coverage Δ
pynetdicom/association.py 100.00% <100.00%> (ø)
pynetdicom/service_class.py 100.00% <100.00%> (ø)

@scaramallion scaramallion changed the title [WIP] Fix LOG_REQUEST_IDENTIFIERS not applying to Associaton send QR methods [MRG] Fix LOG_REQUEST_IDENTIFIERS not applying to Associaton send QR methods May 7, 2024
@scaramallion scaramallion merged commit 667b8a1 into pydicom:main May 7, 2024
11 checks passed
@scaramallion scaramallion deleted the dev-qr-logging branch May 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncontrolled Logging of PHI in Pynetdicom
1 participant